server
server copied to clipboard
Published
20 hours ago •
LandSandBoat
LandSandBoat
[CPP/LUA] Add synthesis high quality related configurable settings
I affirm:
- [x] I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
- [x] I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
- [x] I have read and understood the Contributing Guide and the Code of Conduct.
- [x] I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.
What does this pull request do?
Adds synthesis high quality related configurable settings requested in https://github.com/LandSandBoat/server/discussions/5453
Steps to test these changes
- Tweak the settings
- Attempt to synth or desynth
Several things here:
- Synthesis configurations should all remain together. This should go bellow the existing ones.
- They should all follow the same naming convention. This should all start with
CRAFT_ - I think this is absolutely overkill. Current configurations are there because once upon a time, the system worked with different caps and different rates (era vs modern). HQ rates have never changed, I dont think EVERY single number needs a configuration.
I would limit it to a single HQ chance multiplier. That would seem more reasonable.
Several things here:
- Synthesis configurations should all remain together. This should go bellow the existing ones.
- They should all follow the same naming convention. This should all start with
CRAFT_- I think this is absolutely overkill. Current configurations are there because once upon a time, the system worked with different caps and different rates (era vs modern). HQ rates have never changed, I dont think EVERY single number needs a configuration.
I would limit it to a single HQ chance multiplier. That would seem more reasonable.
Refactored into a single setting that is an additional multiplier applied to chanceHQ.