Woosuk Kwon

Results 151 comments of Woosuk Kwon

@concretevitamin Thanks for your review! While I addressed all of your comments, I found that this PR breaks `sky exec` and `sky launch -c existing-cluster`. For existing clusters, we only...

@concretevitamin I made the compatibility check invoked by the optimizer. Now this PR does not break `sky launch` and `sky exec` on existing clusters. However, a slight downside of this...

I changed the implementation substantially. The PR now consists of two new functions `check_host_accelerator_compatibility` and `check_accelerator_attachable_to_host`. The first `check_host_accelerator_compatibility` function is invoked when `Resources` objects are created. It simply checks...

I've checked that this PR does not break any smoke test.

@concretevitamin If you don't have any more concern about this PR, I'll merge it.

@concretevitamin Sounds good. Then I think we can keep E2 and only remove t2a and f1-micro VMs. WDYT?

@concretevitamin Added the filter in PR #1004.

I'm also wondering if you have any plan to support `delete_remote_dir` or something like that :)

@michaelzhiluo Yeah, I would love Sky Storage more if it supports downloading/removing subdirectories. And actually Sky Benchmark needs it.

@Michaelvll Just curious: Does this problem persist even now? To me, it seems like the auto stop flag is set only after the setup finishes. https://github.com/sky-proj/sky/blob/f13c5280215417a5662a65637209d3248dcd3a8a/sky/execution.py#L156-L161