skypilot icon indicating copy to clipboard operation
skypilot copied to clipboard

Autostop should consider the setup as not idle

Open Michaelvll opened this issue 2 years ago • 4 comments

Our autostop will only consider the run section, but the setup section can take very long and the cluster can be stopped even if the setup is still running.

Michaelvll avatar Apr 05 '22 02:04 Michaelvll

@Michaelvll Just curious: Does this problem persist even now? To me, it seems like the auto stop flag is set only after the setup finishes. https://github.com/sky-proj/sky/blob/f13c5280215417a5662a65637209d3248dcd3a8a/sky/execution.py#L156-L161

WoosukKwon avatar Jul 18 '22 00:07 WoosukKwon

I think the issue is if there's a concurrent sky autostop command. Which will not consider the ongoing user-level setup as "busy".

concretevitamin avatar Jul 18 '22 03:07 concretevitamin

@concretevitamin Got it. Makes sense. Thanks!

WoosukKwon avatar Jul 18 '22 06:07 WoosukKwon

I think the issue is if there's a concurrent sky autostop command. Which will not consider the ongoing user-level setup as "busy".

On Sun, Jul 17, 2022 at 5:38 PM Woosuk Kwon @.***> wrote:

@Michaelvll https://github.com/Michaelvll Just curious: Does this problem persist even now? To me, it seems like the auto stop flag is set only after the setup finishes. https://github.com/sky-proj/sky/blob/f13c5280215417a5662a65637209d3248dcd3a8a/sky/execution.py#L156-L161

— Reply to this email directly, view it on GitHub https://github.com/sky-proj/sky/issues/715#issuecomment-1186645548, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEQWHUB56VZQFT4NPBJSILVUSROTANCNFSM5SRKOO5A . You are receiving this because you are subscribed to this thread.Message ID: @.***>

concretevitamin avatar Oct 11 '22 08:10 concretevitamin