Hlib Kanunnikov

Results 135 comments of Hlib Kanunnikov

Agree with Ryan that more docs for the code are needed

> raud proof request loop does not guarantee to ask 5 different peers for frauds, it only asks 5 times We don't have a check for that. Your case likely...

What's the status of the broken test here? Is it coming from this PR?

Tests failed because`Syncer.Start` now requires initialized `Store`. Fixed now

@renaynay, @distractedm1nd, pls give another read to the docs. I think it's a different level now.

We should not merge this one until we downgrade our network to 0.34. Testing recency on Mamaki is impossible due to bigger block times than they should be. Also, this...

> testing this against arabica and everything looks fine so far -- the problem is not enough blocks have been produced to be able to observe any larger range syncs....

SharesModule is going to be renamed to DataModule as per discussion with @renaynay

Converting to Draft as WIP

@renaynay, let's better keep MetricsModule so that we have ```go type MetricsModule interface { // List shows all the registered meters. List(ctx) (string[], error) // Enable turns on the specific...