WillieHabi

> In addition to the disabled cases, there should be coverage for when target client id is not supported. In those cases, even when a target is specified, all clients...

> Rework once base types are updated. Also expect to see feature support declared. And maybe an option to control it or is that done with versioning? Did the rework...

> Also are there any tests that can happen here? Will look into this Edit: I think the End-To-End client tests would be the most appropriate way to verify if...

I had to solve a merge conflict here after merging #19851 @jason-ha

@znewton @jason-ha I made some changes to accommodate conflicts with this PR being merged https://github.com/microsoft/FluidFramework/pull/19906

@jason-ha I also have some client side type changes here https://github.com/microsoft/FluidFramework/pull/20299

> > Also are there any tests that can happen here? > > The above got a thumbs up, but I am not seeing any units tests. I know there...

> > Also are there any tests that can happen here? > > The above got a thumbs up, but I am not seeing any units tests. I know there...

> > > > Also are there any tests that can happen here? > > > > > > > > > The above got a thumbs up, but I...

> Are we sure that when a client says they support v2 that the only signals we send through are ISentSignalMessage_s? The rest will just get dropped. This doesn't seem...