FluidFramework icon indicating copy to clipboard operation
FluidFramework copied to clipboard

Signals: Target Client ID Test Support

Open WillieHabi opened this issue 1 year ago • 2 comments

Description

ADO Task 7027

Follow up work from https://github.com/microsoft/FluidFramework/pull/17729

  • Add coverage for targetClientId signals scenarios in localTestSignals.spec (disabled since it is not supported)

WillieHabi avatar Jan 29 '24 18:01 WillieHabi

In addition to the disabled cases, there should be coverage for when target client id is not supported. In those cases, even when a target is specified, all clients should get the signal. This we can test right now. One thing I don't recall is whether the target client id comes through to recipients. If so we should have tests that check that aspect is correct.

The current DocumentDeltaConnection submitSignal implementation throws an error if a target client is specified and target client id is not supported.

Screenshot 2024-01-31 at 5 17 18 PM

Not sure if this is the desired functionality, so I will disable the tests for now.

WillieHabi avatar Feb 01 '24 01:02 WillieHabi