William Ayd
William Ayd
I think all feedback here has been addressed - let me know what you think @kou
I don't believe the AppVeyor failure is related
Hmm looks like the build is failing due to some UB: ``` [ RUN ] TestORCWriterSingleArray.WriteStructOfStruct ../src/arrow/adapters/orc/util.cc:216:27: runtime error: signed integer overflow: -4702111234474983746 * 1000000000 cannot be represented in type...
It is reproducible. If you take this branch and do: ``` cd cpp meson setup builddir -Dtests=enabled -Dorc=enabled -Db_sanitize=address,undefined ``` Then you can either run the test suite with ```...
Are you getting any error?
Ah that's interesting. Maybe just doing `-b_sanitize=undefined` will work? I suppose ASAN isn't required to debug this. If not, will look further into what the macOS linker is doing
Maybe the sanitizers aren't supported on arm macs? This homebrew conversation is a few years old but I don't see a resolution: https://github.com/orgs/Homebrew/discussions/3384
Nice! That definitely fixes it - appreciate the help!
Looks like we are down to an ASAN violation on one of the tests now - @wgtmac any ideas on this one? ``` [ RUN ] TestAdapterRead.ReadIntAndStringFileMultipleStripes stderr: AddressSanitizer:DEADLYSIGNAL =================================================================...
Hmm well that is...strange. I also had a hard time reproducing locally, although I was using the wrap file and not a conda-installed orc. Will give that a go and...