William Ayd

Results 421 comments of William Ayd

Thanks @eli-schwartz and @rgommers for the feedback- lots of great consideration points. I'll give meson a look along with this. Sounds like Meson is great for the packages you've pointed...

This is ready for review. In this process a few tests changed around that all seemed to exhibit flakey cross platform behavior. I'm guessing the build flags might be responsible...

@Dr-Irv did you run `cmake .` first? That should configure everything and create CMakeCache.txt

> CMake Error: CMAKE_GENERATOR was set but the specified generator doesn't exist. Using CMake default. I'm guessing this might be the error? > Then left out the target, and got...

Yea I think the different build types got mixed up when running the build without specifying `--config Release` though

Definitely on the tip of this branch right? There were some previous issues where we would build an internal json module and then `import json` From numpy or Cython would...

I have that already in the Meson section. Do you want that moved somewhere else?

I am biased by using it with Arrow, but I find CMake relatively simple to use. Compared to Meson there is way more literature available. You can see this in...

FWIW I also think either will represent a good upgrade over setuptools. I’m not sure we need to decide on one versus other as part of this PDEP as much...

> At this point, I think both POCs have reached the point at which they can reliably compile pandas correctly. We might want to benchmark cmake vs meson and note...