William Ayd

Results 421 comments of William Ayd

I think having two date parsing functions applied to the arrow engine will be problematic. As a somewhat contrived example, if arrow decided at some point to parse a date...

Probably in the minority but I think uint8 is a natural return type. bool would also be ok Int64 and float are pretty heavy handed - I think memory usage...

Yea it could be. I didn't put a lot of time into that yet but if you want to explore would be great. I ideally want CMake to build the...

> Well, I'm not sure I have the time nor understanding to get this working on Windows! Ah sorry...didn't think about make not working on Windows. I think you can...

I think we can drop the minimum CMake version to 3.14 which would help. I just pulled the 3.22 off their documentation, but the NumPy finder was added in 3.14...

Awesome! I think you can tweak those settings via some CMAKE variables: https://stackoverflow.com/questions/45368513/how-to-prevent-cmake-from-creating-debug-release-folders-under-executable-output

FYI the idiomatic approach to CMake is to do an "out of source" build, where we would have a dedicated build sub folder and all required elements would be copied...

Sounds good. Thanks for the feedback so far - very helpful

This should be closer to cross platform. Some notes since @Dr-Irv last tried. 1. The min required version is 3.17 (released March 2020). This is because the Python_SOABI variable was...

Good question to which I do not know the answer. My only reason for picking CMake was familiarity with it through some Arrow work