Wilfred Hughes
Wilfred Hughes
A better heuristic might be looking at the line number of the last change in the file.
It looks like git tries to pass us the mode: ``` static void add_external_diff_name(struct repository *r, struct strvec *argv, const char *name, struct diff_filespec *df) { struct diff_tempfile *temp =...
This is an issue with our git docs, where we suggest explicitly setting the difftool to difftastic with two arguments.
``` dft = "!f() { GIT_EXTERNAL_DIFF=difft git diff --ext-diff $@; }; f" ``` is probably a better setting for .gitconfig
I'm not sure this is something that smartparens can help with. smartparens-strict-mode overrides various edit commands to ensure you have the right number of parens. It can't promise to prevent...
Tests are passing on macOS and Linux, but looks like there's a pre-existing failure on Windows. I think this code is good to merge, but happy to make any changes...
We could create a GitHub repository to host the HTML, and add the key as a secret in an action jobs on this repo. https://surge.sh/ would be another option, it's...
Could you run ocamlformat and update the PR?
The sandcastle module looks wrong, I'm seeing a compile error: ``` Error: Library sandcastle is defined twice: - hack/src/utils/facebook/dune:6 - hack/src/stubs/dune:171 ```
FWIW this isn't passing our CI still: ``` Error: Library sandcastle is defined twice: [...] hphp/hack/facebook/redirect/dune_build/.dune/default/hack/src/stubs/sandcastle/dune:1 - hack/src/utils/facebook/dune:6 ```