Wilfred Hughes comments

Results 601 comments of


                                            Wilfred Hughes

pytest-module fails if file path has a space in it

I think this can be closed now that #12 is merged.

pytest-one complains about 'not an extant file'

Duplicate of #14 I think, which is now fixed.

Useless `"patterns"` array

Would you like to submit a PR?

Various textmate scope improvements

Agreed, I'm open to PRs if you'd like to work on this :)

Allow single-quoted strings to be the same as double-quoted strings

This is intentional I'm afraid. Difftastic is a syntactic differ, and semantic information about which string literals are equivalent are out of scope. In some languages, single-quoted strings and double-quoted...

Allow single-quoted strings to be the same as double-quoted strings

@eduard93 you should be able to change what's considered the content of the Atom when it's a string here: https://github.com/Wilfred/difftastic/blob/b88b4056203cdd3075cd341595411195671a163b/src/parse/syntax.rs#L411 If it's an AtomKind::String, drop the first and last characters...

Allow single-quoted strings to be the same as double-quoted strings

Thinking about this some more, I think this is a worthwhile addition, but language configurations should opt-in to it.

fix: out of bounds panic when diffing large number of words

Thanks for the pull request, and the clear explanation! This sounds like a regression from 8c004be87b5553809d1d865fc76adb754c2c3b55.

fix: out of bounds panic when diffing large number of words

Fixed: https://github.com/Wilfred/difftastic/issues/688#issuecomment-2241316356 Thanks for the PR and the helpful discussion!

Panic index out of bounds in side_by_side.rs on go.sum

Hmm, the pull request fixes the bad_left/right case with colons, but not the go.sum.txt case.