Wilfred Hughes
Wilfred Hughes
OK, so AFAICS the underlying issue is that difftastic assumes that it can split a string on lines, join them later, and get the same string. This isn't true in...
Hmm, so the commit updated the `cc` crate, but I'm surprised it broke the build for you. What platform are you on, with which compilers? This header is part of...
I've updated the Lua parser and cc crate, and CI is still green. Feel free to reopen if you're still seeing issues.
That's correct behaviour I'm afraid. You have a large string (starting at the EOF heredoc), which has partially changed. I'd like to improve the highlighting of large multiline strings, but...
I can reproduce this: ``` function absOZ(int256 n) pure returns (uint256) { unchecked { return uint256(0); } } ``` Produces: ``` source_file (0, 0) - (6, 0) function_definition (0, 0)...
@bors r=@Veykril
lojbo .ui Thanks for the report. I think the first issue is probably trying to diff lines ending \r\n against files ending with just \n and concluding that they're different....
I can repro the second issue, but not the first. Can you reproduce the first issue with local copies of the files? If so, could you attach them here?
OK, I can reproduce the first issue if I have two files that differ by line ending, but I'm not convinced that difftastic's behaviour is wrong here. ``` $ echo...
For what it's worth, `#[cfg(FALSE)]` hasn't changed, it has always shown inactive highlighting across the whole scope. As @davidbarsky mentioned, this was a huge win when we measured it for...