Rik Smale

Results 507 comments of Rik Smale

As maintainer I'm not 100% sure it was a feature, but I can be sure that we have done things that are not the best choice in the current Node.js/ECMAscript...

The current return type in the code is `value is Date`, that could become a boolean to fix the docs. You'll need to update the following line; https://github.com/date-fns/date-fns/blob/c053552651f5354de6bd10cc20ea17a2cc9f7511/src/isDate/index.ts#L33 Further information...

I'm fine with keeping with `value is Date`, but then we'll need to update how the site renders that.

Seems that we've missed this one, thanks for the bump! Can you give a rough idea on what 'recently' means? Is it somewhere within v6.0 and v6.31 or from v5...

Hi! Thanks for opening this issue. Explanation on how to add a new localization can be found in the gherkin repo; https://github.com/cucumber/gherkin/blob/main/CONTRIBUTING.md The docs regularly update the localization based on...

Thanks for reporting this. I think the nicest way of resolving this is to update the `versionQuery` to return the proper version for both the Azure managed version as the...

Do you have the ability to run our integration tests on Azure SQL? If you update the `minimumDatabaseVersion` [here](https://github.com/sequelize/sequelize/blob/c679aa7162e8ed44dba330547ebf24474b079df3/packages/mssql/src/dialect.ts#L123) and the config of the integration tests here; https://github.com/sequelize/sequelize/blob/c679aa7162e8ed44dba330547ebf24474b079df3/packages/core/test/config/config.ts#L46-L64 Then you...

I'd recommend using the v7 alphas instead. DB2 support has been improved there and has become less experimental than in v6. But if the community can make a PR without...

> While I understand that v7 alphas have improved DB2 support, we have concerns about using alpha versions in a production environment due to the potential instability and lack of...

Maybe #2648 can also be fixed with this PR? Since it's the same validator that requires an update