Rik Smale comments

Results 507 comments of


                                            Rik Smale

fix: Safely compare values when unique constraint violation error occurs in findOrCreate

Could you add a test for this that would fail in the current sequelize version but would be fixed with this change?

feat(core): rejectOnEmpty added to ModelOptions

@anthonybudd I got your message and will check this out hopefully within the next week

fix(core): Add `returning` to `DestroyOptions` interface

I couldn't find any tests for the returning property, nor a mention of this feature. Are you sure this is supported?

fix(core): Add `returning` to `DestroyOptions` interface

I think in that case we should add an overload that's only active if `paranoid` is enabled and adds the `BulkUpdateOptions`. Unfortunately this part still has quite some work to...

feat(oracle): Add support for oracle dialect in v7

> I'm eagerly awaiting the `@sequelize/oracle` release for my legacy-app migration. @sudarshan12s, could you please let me know the estimated release date? Is there a chance it might be released...

Fix(isEmail): Added support for internationalized domain names

Please update the README as well, see the checklist in the PR description

fix(isEmail): reject quoted emails with blacklisted characters

We've merged https://github.com/validatorjs/validator.js/pull/2414 in the past. Why do we need this additional one?

fix(core): ensure bulkInsert returns array of inserted IDs

Please adjust the tests and probably add new ones. It could be that we have tests that only check for certain dialects, you'll need to update those expectations as well...

fix(postgres): prevent duplicate unique constraints during sync({ alt…

I've taken another look at this and it seems that the test passes already on the `main` branch. Could it be possible the issue is solved? Or do we need...

fix(snowflake): update snowflake-sdk

Putting this in draft, I will fix the merge conflicts when the other PRs have been merged