Mahatthana (Kelvin) Nomsawadi
Mahatthana (Kelvin) Nomsawadi
@daltojohnso I'll be back on Monday and don't want you to be blocked on this. But I'll make sure I review this when I'm back even if it's already merged.
@daltojohnso The changes look good 👍
I also can't reproduce on Chrome and Brave on Galaxy S22 using: - GBoard - Microsoft Switkey - Samsung Keyboard All show enter key and update the filter correctly 🤔
This is what I got, so I don't think the problem has been fixed yet. (Tested on stats with hash: 05b33c2) #### Dashboard  #### Email 
Closing this as there're some fundamental questions we need to answer first from the product's perspective. Also, it's only a visual bug and isn't a regression.
The reason why the dashboard field isn't populating field values is that when we view the parameter in the native query editor, the field that's passed to the parameter widget...
I found a possible cause introduced by this PR https://github.com/metabase/metabase/pull/18223/files#diff-82a7f4faef021837026f98a1fb4ca767a167bc0a756e50eebc0a046e463567edR384 https://github.com/metabase/metabase/blob/7c4b372e9709a08de5146f65bbafa0ca38c4729a/frontend/src/metabase/meta/Dashboard.js#L384 I'm not sure what that line is supposed to do, but removing that line doesn't fail the test from...
The above assumption (removing `.map(field => field.target ?? field)`) breaks the test `should work for the foreign key` in `e2e/test/scenarios/dashboard-filters/dashboard-filters-id.cy.spec.js`
Reproducible on 1.42, but fixed in master (e0ebd085cc168d75692c4ec584bb71994011dc83) 
[We discussed that](https://metaboat.slack.com/archives/C057T1QTB3L/p1689971581589849) the fix is to prevent dashboards from being editable on mobile.