metabase icon indicating copy to clipboard operation
metabase copied to clipboard

Cannot edit dashboard filter mapping on mobile

Open WiNloSt opened this issue 3 years ago • 1 comments

Fixes #23962

This PR fixes the issue by wrapping the dashboard content down at the bottom.

Before

Desktop

image

Mobile

  1. Before editing image

  2. Clicked editing. You could see the dashboard width is almost 0 (shrunk via flex-shrink) image

After

Desktop (looks the same)

image

Mobile

  1. Before editing image

  2. Clicked editing image

  3. Scroll image

WiNloSt avatar Aug 03 '22 09:08 WiNloSt

Codecov Report

Merging #24547 (863d574) into master (a54b36b) will decrease coverage by 0.00%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master   #24547      +/-   ##
==========================================
- Coverage   65.27%   65.26%   -0.01%     
==========================================
  Files        2775     2787      +12     
  Lines       85123    85154      +31     
  Branches    10497    10508      +11     
==========================================
+ Hits        55563    55575      +12     
- Misses      25228    25246      +18     
- Partials     4332     4333       +1     
Flag Coverage Δ
front-end 46.42% <0.00%> (-0.01%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ashboard/components/Dashboard/Dashboard.styled.jsx 0.00% <ø> (ø)
...tend/src/metabase/dashboard/components/Sidebar.jsx 0.00% <ø> (ø)
...rc/metabase/dashboard/components/Sidebar.styled.ts 0.00% <0.00%> (ø)
...etabase/parameters/components/ParameterSidebar.jsx 0.00% <ø> (ø)
...e/parameters/components/ParameterSidebar.styled.ts 0.00% <0.00%> (ø)
...alizations/components/ChartClickActions.styled.tsx 16.66% <0.00%> (-33.34%) :arrow_down:
...tend/src/metabase/containers/ItemPicker.styled.tsx 75.00% <0.00%> (-25.00%) :arrow_down:
frontend/src/metabase/containers/ItemPicker.jsx 64.00% <0.00%> (-0.48%) :arrow_down:
frontend/src/metabase/redux/metadata.js 46.15% <0.00%> (-0.35%) :arrow_down:
...nd/src/metabase/query_builder/actions/core/core.js 22.61% <0.00%> (-0.28%) :arrow_down:
... and 34 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Aug 03 '22 09:08 codecov[bot]

Closing this as there're some fundamental questions we need to answer first from the product's perspective. Also, it's only a visual bug and isn't a regression.

WiNloSt avatar Oct 25 '22 08:10 WiNloSt