WestLangley

Results 239 comments of WestLangley

>@WestLangley btw to clear things up, @DanielSturk is working with me to porting back some of our private ThreeJS changes into ThreeJS mainline I see. This PR was filed with...

>I also added the MeshCubeMaterial to the WebGLBackground I would request that you remove that for now since it changes the background behavoir, and the current background code works fine...

@mrdoob, an alternative to adding `THREE.SkyboxMaterial` is to add `THREE.Skybox`, instead. It may be more handy as it could automate things such as: ```js skybox.onBeforeRender = function ( renderer, scene,...

Should the `dat.gui` provide a roughness control? Maybe in a later PR? In the mean time, this is what is rendered for me. Do you get the same result? ![Screen...

>That looks correct to me Sorry, but there is no way that is correct. Compare with http://threejs.org/examples/webgl_materials_envmaps_hdr.html.

> I added renderer.gammaOutput=true to this demo so that you can compare them more easily. You don't add that so @WestLangley can "compare them more easily". You add it because...

@DanielSturk This is almost ready if you can fix the LDR case... :-)

@DanielSturk I will continue help you fix your code... First, revert the last commit. You need to covert from linear space to gamma-corrected color space. Second, properly set the encoding...

@bhouston See if you can provide Daniel some references about rendering in linear colorspace so he understands the issue and we can get this PR merged. I have done my...