Daniel Walsh

Results 74 comments of Daniel Walsh
trafficstars

I appreciate the PR, there are definitely some improvements to be done in formatting. The way of storing this data also seems very awkward. Storing it in the block itself...

PR looks good aside from the comment I still have open.

I don't understand the issue, could you please record it and show `/sf versions` in the recording.

https://cdn.discordapp.com/attachments/849633185003733023/849633251550691369/2021-05-31_01-40-41_Scene_Trim.mp4 Video from user

> A quick question might be completely out kf the scope of this pr/draft but will this mean db support for like sql or maria or what ever? It's a...

Stated comments in Discord but otherwise looks alright.

Easy fix, that permission check should just be moved into the item != null check. It's checking permission BEFORE checking if there's a plant actually there (also needs to handle...

Appreciate it @KianNH 👍 Tested this out and it's good to

Hey, This does not seem to be a real problem since the repro is hard and it just requires a re-auth.

Tracking in https://github.com/cloudflare/pages-action/issues/16 The Wrangler action is unlikely to get this, we would suggest (and be open to PRs adding it) to use the pages-action instead.