Slimefun4 icon indicating copy to clipboard operation
Slimefun4 copied to clipboard

WIP - Refactored config handling + Added /sf reload

Open TheBusyBiscuit opened this issue 4 years ago • 2 comments
trafficstars

Description

This pull requests moves the config-related stuff from SlimefunRegistry to a dedicated Config Manager. It also allows some basic reload functionality,, accessible via /sf reload (Many people requested this for a long time). Note that this is not fully finished though, so not all changes are supported and a lot will still require a restart.

Changes

  • Added /sf reload
  • Added Config Manager to handle our configs
  • All relevant config files have been moved to this Config Manager class
  • All relevant cached data was moved to the Config Manager too

Checklist

  • [x] I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • [x] I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
  • [x] I followed the existing code standards and didn't mess up the formatting.
  • [x] I did my best to add documentation to any public classes or methods I added.
  • [x] I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
  • [ ] I added sufficient Unit Tests to cover my code.

TheBusyBiscuit avatar Feb 13 '21 12:02 TheBusyBiscuit

Your Pull Request was automatically labelled as: "🧹 Chores" Thank you for contributing to this project! ❤️

TheBusyBot avatar Feb 13 '21 12:02 TheBusyBot

PR looks good aside from the comment I still have open.

WalshyDev avatar Apr 10 '21 17:04 WalshyDev

Closing this Superceding with an up to date branch #3908

J3fftw1 avatar Jul 29 '23 16:07 J3fftw1