Slimefun4
Slimefun4 copied to clipboard
WIP - Refactored config handling + Added /sf reload
trafficstars
Description
This pull requests moves the config-related stuff from SlimefunRegistry to a dedicated Config Manager.
It also allows some basic reload functionality,, accessible via /sf reload (Many people requested this for a long time).
Note that this is not fully finished though, so not all changes are supported and a lot will still require a restart.
Changes
- Added /sf reload
- Added Config Manager to handle our configs
- All relevant config files have been moved to this Config Manager class
- All relevant cached data was moved to the Config Manager too
Checklist
- [x] I have fully tested the proposed changes and promise that they will not break everything into chaos.
- [x] I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
- [x] I followed the existing code standards and didn't mess up the formatting.
- [x] I did my best to add documentation to any public classes or methods I added.
- [x] I have added
NonnullandNullableannotations to my methods to indicate their behaviour for null values - [ ] I added sufficient Unit Tests to cover my code.
Your Pull Request was automatically labelled as: "🧹 Chores" Thank you for contributing to this project! ❤️
PR looks good aside from the comment I still have open.
Closing this Superceding with an up to date branch #3908