Daniel Walsh

Results 74 comments of Daniel Walsh
trafficstars

No I don't have it publically available as it simply just doesn't work right currently. I could provide you the standalone migration tool that (I think it's slightly behind) I...

First thoughts: This is an interesting PR and I understand the reasoning why. I have a few questions however: 1. Do you believe this is better than just improving the...

> Likely not, but any improvements to the existing system would likely unify how any Slimefun inventory is looked at by anything which would, in turn, mean a big change...

Taken a look into this, we drop the item naturally rather than adding to drops (I know we disable drops but still causes issues due to plugins not knowing about...

> @WalshyDev SilkSpawners-API doesn't really allow us to fix this without changes to it. They don't exactly expose much, we looked into this in the past. what do you mean?...

> > what do you mean? We eiher need to cancel the event or change the ItemStack being dropped. Not sure what we even want the behaviour to be for...

I feel like making a debug thing for you guys. Something that dumps all the events being fired and which are being handled by Slimefun. Then it can also dump...

So, I see 2 ways to probably solve this: 1. EcoEnchants simply hooks into SF and listens to our event + cancels 2. We fire an enchant event for other...

Hmm, I'm not sure how to handle this. I'd like to try and not revert but how do we know if it's an item to check lore of. Any ideas...

Could you please cleanup the changelog?