Slimefun4 icon indicating copy to clipboard operation
Slimefun4 copied to clipboard

Fix Book Binder

Open svr333 opened this issue 2 years ago • 3 comments

Description

Currently there is an issue with the Book Binder. If you combine 2 books of the same level and the resulting level will go above the set limit (either vanilla or custom) the books will combine into one and keep their current level.

This fix makes it so that if a Fortune III gets combined with another Fortune III, it will not be combined into another Fortune III (granted there is no custom limit) This has no effect for books with multiple enchantments as both books have the same level

Proposed changes

  • Fix books being consumed and returning their current value

Checklist

  • [x] I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • [x] I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
  • [x] I followed the existing code standards and didn't mess up the formatting.
  • [ ] I did my best to add documentation to any public classes or methods I added.
  • [ ] I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
  • [ ] I added sufficient Unit Tests to cover my code.

svr333 avatar Oct 03 '21 11:10 svr333

Could you please cleanup the changelog?

WalshyDev avatar Jan 18 '22 16:01 WalshyDev

just remove the changelog changes?

svr333 avatar Jan 18 '22 17:01 svr333

Sorry for the commit mess

svr333 avatar Jan 19 '22 16:01 svr333

Would someone want to test these changes again to be sure everything works as intended that way we don't have the mess that was the last enchantment related PR.

JustAHuman-xD avatar Jun 12 '23 10:06 JustAHuman-xD

Closing this in favour of #3925

J3fftw1 avatar Aug 05 '23 23:08 J3fftw1