Charles Dang

Windows CI vcpkg failure

8

The Windows CI is currently failing with a vcpkg error when downloading pango. It claims the hash on the package (downloaded from the pango GitLab page) is incorrect. Manually fetching...

Upgrade to Lua 5.5

1

Lua 5.5 RC 1 just released last week. Once it's finally stable, we should look to upgrading, possibly for 1.21. Opening this as a reminder. Major changes are listed here:...

GUI2 event handling causes crash if modeless dialog is closed in key press callback

11

Did some debugging. Looks like it has to do with more events being executed by the dispatcher on the destroyed dialog object after it closes. Not sure why. Setting `handled`...

One-frame graphics lag for certain animated graphics

1

This is most visible in TSG, where the floating "click here" arrows show a distinct break when they pass over the bounding box of the unit's hex. I suspect it...

Make lexical_cast non-throwing

4

Toward #10427. lexical_cast now returns optional instead of throwing bad_lexical_cast on failure. This allows the code to be simplified by letting the caller handling the nonexistent value. lexical_cast_default still returns...