Charles Dang
Charles Dang
`map_location`, as well as a ton of the formula_callable objects, all define `do_compare` functions for three-way comparison. These should be replaced with the spaceship operator in C++20. It doesn't look...
Looking through the various ability/unit/terrain filters that handle adjacent locations, I noticed that they don't consistently handle (or at least, it's not obviously consistent) cases where the adjacency key isn't...
They really didn't need to be shared_ptrs, except it was easier to copy things around (especially when builders held containers of builder ptrs). This makes all widget_builder::build overrides non-const to...
Instead of constructing an intermediate list whose special members (wml items, autosaves, etc) are then expanded, simply append the expanded items on the initial pass. Also optimizes the case where...
Attempting to fix #7948, I realized that the menu labels provided by `wmi_manager::get_items` later gets overwritten by `command_executor::get_menu_images`. When adding a simple menu item to a scenario, like so: ```...
This delegates most of the internal logic to a static factory. The main benefit is this utilizes SDL_Image's direct-to-texture methods rather than running everything through the surface pipeline. I'm still...
Reduces manual memory management by using unique_ptr. Doesn't (yet) touch `document::buffers_` since that's a slightly more in-depth change.
While testing some `surface` [logging code](https://github.com/wesnoth/wesnoth/commit/5a0658401201ca746cf786b4f8533627281061b8), I discovered that it's possible for [this line](https://github.com/wesnoth/wesnoth/blob/master/src/log.cpp#L435) to be null and hence to crash the game. It seems the only way that would...