Charles Dang
Charles Dang
Agreed RE logging at static initialization time. And if it's not a static init issue, I need to track down how exactly the logger is still null at the point...
I say let's remove the last one, and also the one celmin is talking about.
Sorry, I was thinking of one of the existing images (the one with the elven sword not done by LordBob). But for this just remove the last one.
I'm fine keeping the elven sword. The problem with the hills image is it's just not visually interesting. It's quite flat, the colors are muted, and it looks more like...
I meant the last image proposed for addition in the OP.
The underlines are there for me as well... What Pango version are you building with?
All this does is smartly handle deletion in the exact same place where the objects are current deleted. There isn't even refcount overhead. It's about as minimal of a change...
Test failure is break_replay_with_lua_random.
We profiled using config a while back, and it performed worse than simple_wml. I don't think it's worth replacing it wholesale, but QoL improvements are good.
Anything left on this?