Jinjing Zhou
Jinjing Zhou
Looks very nice to me. Some thoughts - For the remove part, one thing needs to be decided is whether to free the memory immediately, or set an upper limit...
@cbalioglu TTL seems a graceful solution to me. Also I'd like to add another scenario need torchstore. In the rpc scenario, the server may take long time to handle a...
> Since the high level description of the project is "TorchStore is a key-value store that holds ATen tensors in shared memory ...", I wonder if it's ideal to support...
Thanks for your work! I just think it's a widely needed component for all DL framework. It's really a meaningful work!
Hi, I still meet this problem with the latest master branch. The type in `kaHIP_interface.h` is still int when compiling with 64BITMODE
@schulzchristian I feel it's complicated. The signatures in https://github.com/KaHIP/KaHIP/blob/2158c5b6c07ae1b5755bcda6ea7adbca1a3618a2/interface/kaHIP_interface.cpp are all int. Is it safe to replace them with `EdgeID` or `NodeID`?
Thanks for reporting this. We're planning to fix this at https://github.com/dmlc/dgl/pull/3249
Not related to effort, but potential compatibility issue. @BarclayII Why didn't we upgrade the whole dlpack in dgl instead of making a patch? I remember there's some backward compatibility issue.
Can our nightly build solve your issue? We have nightly build for linux, which is available through `pip install --pre dgl-cuXX`
The current color pattern doesn't seem good. Any suggestion is welcomed