dgl icon indicating copy to clipboard operation
dgl copied to clipboard

canonical_etypes should be used in dgl.distributed.partition_graph

Open Sherler opened this issue 4 years ago • 2 comments

🐛 Bug

To Reproduce

Steps to reproduce the behavior:

  1. define two edge types with same 'middle name': (person,loves,person) ,(person, loves, pet)
  2. create partition_graph using dgl.distributed.partition_graph
  3. there will be an exception:
dgl._ffi.base.DGLError: Edge type "loves" is ambiguous. Please use canonical edge type in the form of (srctype, etype, dsttype)

Environment

  • DGL Version (e.g., 1.0): 0.7.1
  • Backend Library & Version (e.g., PyTorch 0.4.1, MXNet/Gluon 1.3):
  • OS (e.g., Linux):
  • How you installed DGL (conda, pip, source):
  • Build command you used (if compiling from source):
  • Python version:
  • CUDA/cuDNN version (if applicable): 10.2
  • GPU models and configuration (e.g. V100):
  • Any other relevant information:

Additional context

Sherler avatar Oct 22 '21 12:10 Sherler

Thanks for reporting this. We're planning to fix this at https://github.com/dmlc/dgl/pull/3249

VoVAllen avatar Oct 25 '21 06:10 VoVAllen

This issue has been automatically marked as stale due to lack of activity. It will be closed if no further activity occurs. Thank you

github-actions[bot] avatar Jan 29 '22 01:01 github-actions[bot]

As canonical etypes are not used in partition_graph() yet. Let me re-open this ticket.

  • [ ] use canonical etypes when partition graph including partition_graph() and dist partition pipeline.
  • [ ] load partitions and parse canonical etypes directly in DistGraph instead of going through different partitions.
  • [ ] throw exception if loading deprecated configuration json. update corresponding doc.

Rhett-Ying avatar Oct 19 '22 04:10 Rhett-Ying