Felix Paulusma
Felix Paulusma
[`ruleADuration` in `Duckling.Time.NL.Rules`](https://hackage.haskell.org/package/duckling-0.2.0.0/docs/src/Duckling.Time.NL.Rules.html#ruleADuration) has a German pattern, instead of a Dutch one. EDIT: Also these - `ruleAfterNextTime` - `ruleIntersectByOfFromS` - `ruleWithinDuration` - `ruleTimeofdaySharp` - `ruleIntersectBy` - `ruleLunch`
Maybe it's nice to also have a `strippedSafeToJSON` that's defined as `removeVersion . safeToJSON`? And maybe add like `strippedEncode` defined as `encode . strippedSafeToJSON`?
The `SafeJSON a =>` constraint in the `Product` instance might be superfluous. I remember removing it from `Sum`, because it wasn't necessary, but I guess I might have forgotten to...
The test functions like `migrateRoundTripProp` don't need a second type application. Adjust examples, but note that adding the second type gives guarantee it's migrating from the right type.
Would a `getVersion :: Aeson.Value -> Maybe (Version a)` be a good addition?
This might help in switching from `aeson` over to `safe-json` and make functions like `removeVersion` clearer in that they remove the "safeness".
Since `safe-json-1.0.0`, the `SafeJSON` class doesn't require `FromJSON` or `ToJSON` instances (but still defaults to those if not defined) so a review of the documentation might be in order. (also...
I've been debugging for a few hours and getting really annoyed that HLS just didn't work out of the box, and even with tons of fiddling, it would not get...
I feel that at least the following functions should have less restrictive type signatures: `C) {current signature}` `P) {proposed signature}` ``` C) insertWith :: Ord k => (a -> a...
An attempt at making a better Auth instance of `HasServer`. Also added an example of how this would make for easy adding of different auth procedures. Any comments, critiques, etc....