duckling icon indicating copy to clipboard operation
duckling copied to clipboard
verified publisher icon facebook

Language oopsie in Duckling.Time.NL.Rules

Open Vlix opened this issue 4 years ago • 3 comments

ruleADuration in Duckling.Time.NL.Rules has a German pattern, instead of a Dutch one.

EDIT: Also these

  • ruleAfterNextTime
  • ruleIntersectByOfFromS
  • ruleWithinDuration
  • ruleTimeofdaySharp
  • ruleIntersectBy
  • ruleLunch

Vlix avatar Apr 17 '21 04:04 Vlix

Wow! This must've not been reviewed properly internally. Bad copy/paste error I am guessing. Nice catch.

Would you happen to be interested in preparing a PR?

chessai avatar Apr 18 '21 22:04 chessai

Personally don't have much time to do this at the moment.

Vlix avatar Apr 22 '21 21:04 Vlix

Personally don't have much time to do this at the moment.

No problem, thanks for reporting the issue!

chessai avatar Apr 23 '21 19:04 chessai