Vincent Langlet
Vincent Langlet
> Here you are :) > > https://github.com/shopware/platform/blob/dea144715a735c2b6f53098b9c92f9eeebc16c21/src/Core/Framework/Test/DependencyInjection/CompilerPass/FilesystemConfigMigrationCompilerPassTest.php#L60 I ran ``` git clone ... composer install php src/Core/DevOps/StaticAnalyze/PHPStan/phpstan-bootstrap.php vendor/bin/phpstan analyse src/Core/Framework/Test/DependencyInjection/CompilerPass/FilesystemConfigMigrationCompilerPassTest.php ``` And got no error
> @shyim clearly misunderstood what @VincentLanglet meant with "Best would be to reproduce this error with the tests of this repository". Yes, but if I could have been able to...
I reproduced the error with his repository. I have ``` local /Users/vincentl/Perso/platform/public local /Users/vincentl/Perso/platform/public ``` And with the code ``` $this->builder->setParameter('shopware.filesystem.theme', ['foo' => 'foo']); $this->builder->setParameter('shopware.filesystem.theme.type', 'amazon-s3'); $this->builder->setParameter('shopware.filesystem.theme.config', ['test' => 'test']);...
To simplify the issue ``` $builder = new ContainerBuilder(); \PHPStan\dumpType($builder->getParameter('shopware.filesystem.public')); ``` is reported by phpstan ``` Dumped type: array{type: string, config: array{root: string}} ``` To me this is wrong, but...
Do you think this can be done by this extension @ondrejmirtes ? Any recommendation how-to ? I can try
Friendly ping @ondrejmirtes if you have time to take a look
> I have around 70 unread emails in my inbox after vacation, I'm going from the oldest thread, if you ping here, it means I'm gonna look at it last...
Friendly ping, in case the notification got lost @ondrejmirtes ^^'
I'll close this since it was released in Symfony 4.4, 5.4 and 6.x. People just have to use the latest versions.
I think there is no test so far about this constantHasser config. Might be worth to add some ; do you want to do it @alexander-schranz ? It might help...