phpstan-symfony
phpstan-symfony copied to clipboard
Fix exception thrown by Command::run
Command::run is doing
try {
$input->bind($this->definition);
} catch (ExceptionInterface $e) {
if (!$this->ignoreValidationErrors) {
throw $e;
}
}
And the bind method is only throwing ExceptionInterface
so the run method is supposed to thrown only ExceptionInterface
and not \Exception
which is too generic.
This avoid error with static analysis when we ignore some kind of exception thrown.
Friendly ping @ondrejmirtes if you have time to take a look
I have around 70 unread emails in my inbox after vacation, I'm going from the oldest thread, if you ping here, it means I'm gonna look at it last 😊
I have around 70 unread emails in my inbox after vacation, I'm going from the oldest thread, if you ping here, it means I'm gonna look at it last 😊
Oh ok. Do you getting an email for every created PR/opened issues on every phpstan repository ?
Have good vacation then
Yes, and every comment and every push too 😊
Friendly ping, in case the notification got lost @ondrejmirtes ^^'
I'll close this since it was released in Symfony 4.4, 5.4 and 6.x. People just have to use the latest versions.