Vincent Shen

Results 36 comments of Vincent Shen

I think the content looks good! No sure why did some of the unit test are failing

Remove e2e test, `rhcos4-moderate` profile has different default variable for `var_system_crypto_policy` than `rhcos4-e8`, this makes the first scan fail on `rhcos4-e8` but not on `rhcos4-moderate`.

> So now the tests related to your rule are all passing, but here is this failure: > > ``` > helpers.go:812: Excluded Rule from counting - Name: e2e-high-master-configure-usbguard-auditbackend >...

> test cases details could be seen from: https://url.corp.redhat.com/8162b96 @Vincent056 Could you please help to review? Thanks. Thanks for adding the test case, it looks good to me

wouldn't this check all rendered `rendered-master-*` and `rendered-worker-*`? since MCO doesn't delete the old rendered machine config

I just realized this has to be enabled during the install time, so all rendered machine configs should have it.

I think it makes sense, but if we need to check if `makeIPTablesUtilChains` doesn't exist in other config files?