content icon indicating copy to clipboard operation
content copied to clipboard

Parameterize kubernetes worker rules

Open rhmdnd opened this issue 3 years ago • 6 comments

Some of the worker rules are used in both EKS and OpenShift profiles. This commit updates the rules to use parameters based on the product (either EKS or OCP) so that the descriptions, rationale, and OCIL are accurate for the user and don't bleed across products.

This is related to issue #8198

Description:

  • Description here. Replace this text. Don't use the italics format!

Rationale:

  • Rationale here. Replace this text. Don't use the italics format!

  • Fixes # Issue number here (e.g. #26) or remove this line if no issue exists.

rhmdnd avatar Feb 10 '22 21:02 rhmdnd

Start a new ephemeral environment with changes proposed in this pull request:

Open in Gitpod

github-actions[bot] avatar Feb 10 '22 21:02 github-actions[bot]

/retest

Vincent056 avatar Feb 10 '22 21:02 Vincent056

I think the content looks good! No sure why did some of the unit test are failing

Vincent056 avatar Feb 10 '22 22:02 Vincent056

@rhmdnd: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar Apr 09 '22 22:04 openshift-ci[bot]

@rhmdnd: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ocp4-cis 2afcd1bec9e166288b77ff709fe93836bfd59b87 link true /test e2e-aws-ocp4-cis
ci/prow/e2e-aws-ocp4-pci-dss 2afcd1bec9e166288b77ff709fe93836bfd59b87 link true /test e2e-aws-ocp4-pci-dss
ci/prow/e2e-aws-ocp4-moderate 2afcd1bec9e166288b77ff709fe93836bfd59b87 link true /test e2e-aws-ocp4-moderate
ci/prow/e2e-aws-ocp4-moderate-node 2afcd1bec9e166288b77ff709fe93836bfd59b87 link true /test e2e-aws-ocp4-moderate-node
ci/prow/e2e-aws-ocp4-high-node 2afcd1bec9e166288b77ff709fe93836bfd59b87 link true /test e2e-aws-ocp4-high-node
ci/prow/e2e-aws-ocp4-stig-node 2afcd1bec9e166288b77ff709fe93836bfd59b87 link true /test e2e-aws-ocp4-stig-node
ci/prow/e2e-aws-ocp4-stig 2afcd1bec9e166288b77ff709fe93836bfd59b87 link true /test e2e-aws-ocp4-stig

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Jun 21 '22 17:06 openshift-ci[bot]

@rhmdnd please resolve the conflicts

jan-cerny avatar Jun 29 '22 14:06 jan-cerny

Closing because of inactivity. Feel free to reopen if you want this to get merged.

jan-cerny avatar Aug 24 '22 11:08 jan-cerny