Kevin Zander
Kevin Zander
https://github.com/ansible/ansible/blob/devel/lib/ansible/playbook/role_include.py#L154 Removing `basename` should be all that's needed as validation is still run on the path and will error if it's not within the role directory. I wrote some tests...
My PRs: * #5123 approved but needs testing, no conflicts * #5124 approved but needs testing, no conflicts * #5174 need to update IRT one review, has conflicts easy to...
A couple followup questions: What about sharps and flats? Would the octave number need to be changed as well? I'm assuming yes.
> Also, does LMMS use .sqlite somewhere to read/write configs? No, the save format is XML.
> What would be the reason to elliminate Qt methods? FWIR, this is only useful for the GUI, which uses Qt anyways? Good question! Here's the reason this PR exists:...
> Well, I mean, you can merge two `encode` functions using `std::string_view` and optionally add `std::string`/`const char*, size_t` variants. Oh! I thought you were only talking about the `std::string` ones....
> Suggesting to add a few simple "unit tests", because it should be easy to test and helps us verifying it works. Done. Also changed the current Qt-based encode/decode namespace...
> Why in `lmms::gui`? We're removing Qt from core, but the base64 methods has nothing to do with GUI. Whenever I left them in the same namespace I was getting...
Somewhat related: #241
Not sure if this is the right place to comment for this, but I wanted to better organize, format, and generally prettify the Coding Conventions page for easier reading. Are...