Freya Gustavsson

Results 314 comments of Freya Gustavsson

Could someone take this up at some point and review it?

@andrew-ronaldson I filed search issue in #4472. I might've been a bit unclear but with this issue I meant that the URL is showing www.patternfly.org instead of the archive for...

> [@Venefilyn](https://github.com/Venefilyn) sorry for the delay on this. Did that styling come from patternfly CSS? If I add a form group with an inline list of checkboxes in a control...

Rebased and [added pixel tests](https://github.com/cockpit-project/pixel-test-reference/compare/860f4e8d5594c9f2b2432380f487f59726cf3c9e..fca1ea17871f7d067ed8d7c1a30c1f0bc318216a) from - https://cockpit-logs.us-east-1.linodeobjects.com/pull-22012-f96a9379-20250516-141441-fedora-41-networking/log.html - https://cockpit-logs.us-east-1.linodeobjects.com/pull-22012-f96a9379-20250516-141442-fedora-41-other/log.html - https://cockpit-logs.us-east-1.linodeobjects.com/pull-22012-f96a9379-20250516-141441-fedora-41-storage/log.html

Pixel diff https://github.com/cockpit-project/pixel-test-reference/compare/e287c41746822b2281ceab7de4bebef16efbede0..8acef9e93fa453a41b36a68269c037e0cf9239d3 Taken from https://cockpit-logs.us-east-1.linodeobjects.com/pull-22012-c07b180d-20250627-113935-fedora-41-storage/log.html https://cockpit-logs.us-east-1.linodeobjects.com/pull-22012-c07b180d-20250627-113935-fedora-41-other/log.html https://cockpit-logs.us-east-1.linodeobjects.com/pull-22012-c07b180d-20250627-113936-fedora-41-networking/log.html

Edit: Outdated, moved to https://github.com/cockpit-project/cockpit/pull/22272 --- Network MTU has been changed to fit better. Previously, the label text and text input was both on the same line but this was...

> This would remove the border on mobile as can be seen [here](https://cockpit-logs.us-east-1.linodeobjects.com/pull-22011-a9f66617-20250516-124434-fedora-41-storage/pixeldiff.html#TestStorageStratis-testBasic-fsys-rows-mobile) is that expected? Yeah maybe not the best. I added the border back in for table cards...

@mcoker ah thanks! I assume that was supposed to be in response to #7414? :D

For this issue, there is also a problem with bigger text sizes in general as it would be unaligned. Not sure if there is a good way to center it...

@mcoker ~~seems like this was changed _a bit_ in PF 6.3.1.~~ (Edit: there was a PR that changed the button [to be small in compact PF-React](https://github.com/patternfly/patternfly-react/pull/11947), but that also made...