css: Remove overrides
This removes a bunch of overrides that no longer seem to serve a purpose. Tests will indicate otherwise.
Signed-off-by: Freya Gustavsson [email protected]
Rebased and added pixel tests from
- https://cockpit-logs.us-east-1.linodeobjects.com/pull-22012-f96a9379-20250516-141441-fedora-41-networking/log.html
- https://cockpit-logs.us-east-1.linodeobjects.com/pull-22012-f96a9379-20250516-141442-fedora-41-other/log.html
- https://cockpit-logs.us-east-1.linodeobjects.com/pull-22012-f96a9379-20250516-141441-fedora-41-storage/log.html
Pixel diff https://github.com/cockpit-project/pixel-test-reference/compare/e287c41746822b2281ceab7de4bebef16efbede0..8acef9e93fa453a41b36a68269c037e0cf9239d3
Taken from https://cockpit-logs.us-east-1.linodeobjects.com/pull-22012-c07b180d-20250627-113935-fedora-41-storage/log.html https://cockpit-logs.us-east-1.linodeobjects.com/pull-22012-c07b180d-20250627-113935-fedora-41-other/log.html https://cockpit-logs.us-east-1.linodeobjects.com/pull-22012-c07b180d-20250627-113936-fedora-41-networking/log.html
Edit: Outdated, moved to https://github.com/cockpit-project/cockpit/pull/22272
Network MTU has been changed to fit better. Previously, the label text and text input was both on the same line but this was now changed as more overrides were removed. With the override removal this fixes the alignment issue that was present in previous pixel tests.
How it is right now
And if we remove the existing overrides we get this:
After removing some more overrides we get this:
We could also do this but means we have it like current production where the input is within a label for the radio. Which isn't ideal as it shows the hover/"can be selected" effect but not being selected.
After the most recent push this still regresses.
Re-triggered the tests
Still fails, on pixel tests, going to slap a no-test on it so we can just run fedora-42/*