cockpit icon indicating copy to clipboard operation
cockpit copied to clipboard

css: Remove overrides

Open Venefilyn opened this issue 7 months ago • 1 comments

This removes a bunch of overrides that no longer seem to serve a purpose. Tests will indicate otherwise.

Signed-off-by: Freya Gustavsson [email protected]

Venefilyn avatar May 16 '25 14:05 Venefilyn

Rebased and added pixel tests from

  • https://cockpit-logs.us-east-1.linodeobjects.com/pull-22012-f96a9379-20250516-141441-fedora-41-networking/log.html
  • https://cockpit-logs.us-east-1.linodeobjects.com/pull-22012-f96a9379-20250516-141442-fedora-41-other/log.html
  • https://cockpit-logs.us-east-1.linodeobjects.com/pull-22012-f96a9379-20250516-141441-fedora-41-storage/log.html

Venefilyn avatar May 28 '25 14:05 Venefilyn

Pixel diff https://github.com/cockpit-project/pixel-test-reference/compare/e287c41746822b2281ceab7de4bebef16efbede0..8acef9e93fa453a41b36a68269c037e0cf9239d3

Taken from https://cockpit-logs.us-east-1.linodeobjects.com/pull-22012-c07b180d-20250627-113935-fedora-41-storage/log.html https://cockpit-logs.us-east-1.linodeobjects.com/pull-22012-c07b180d-20250627-113935-fedora-41-other/log.html https://cockpit-logs.us-east-1.linodeobjects.com/pull-22012-c07b180d-20250627-113936-fedora-41-networking/log.html

Venefilyn avatar Jun 27 '25 13:06 Venefilyn

Edit: Outdated, moved to https://github.com/cockpit-project/cockpit/pull/22272


Network MTU has been changed to fit better. Previously, the label text and text input was both on the same line but this was now changed as more overrides were removed. With the override removal this fixes the alignment issue that was present in previous pixel tests.

How it is right now image

And if we remove the existing overrides we get this: image

After removing some more overrides we get this: image

We could also do this but means we have it like current production where the input is within a label for the radio. Which isn't ideal as it shows the hover/"can be selected" effect but not being selected. image

Venefilyn avatar Jul 25 '25 17:07 Venefilyn

After the most recent push this still regresses.

jelly avatar Jul 28 '25 07:07 jelly

Re-triggered the tests

jelly avatar Aug 19 '25 12:08 jelly

Still fails, on pixel tests, going to slap a no-test on it so we can just run fedora-42/*

jelly avatar Aug 19 '25 12:08 jelly