cockpit icon indicating copy to clipboard operation
cockpit copied to clipboard

storage: Fix section spacing

Open Venefilyn opened this issue 7 months ago • 3 comments

We had a bit too much spacing between cards that caused issues with storage mobile-view. Reverting this to how we had it before.

This also removes the border between cards for the storage page and instead only keeps them for the table-style of cards we have between storage types.

Future improvements would be to

  • Remove usage of Card for Storage page sections or embrace it fully
  • Remove usage of Card for mobile-view rows and instead use Table or Data list component

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2366666 Signed-off-by: Freya Gustavsson [email protected]

Venefilyn avatar May 16 '25 12:05 Venefilyn

This would remove the border on mobile as can be seen here is that expected?

jelly avatar May 20 '25 07:05 jelly

This would remove the border on mobile as can be seen here is that expected?

Yeah maybe not the best. I added the border back in for table cards so will look like before but without the extra spacing at least

Venefilyn avatar May 20 '25 12:05 Venefilyn

The pixel tests now conflict.

jelly avatar May 28 '25 08:05 jelly