Max Gautier
Max Gautier
End result looks good. I have three more things: - could you mark the sidebar as generated so the diff does not show up in PRs ? This is helpful...
> I restructured the commits and added a pre-commit-hook that checks if a file was added in the docs folder, if that is the case it checks if the _sidebar.md...
On Thu, May 16, 2024 at 03:53:06AM -0700, Alexander wrote: > Yes I thought about it but after my research about pre-commit hooks I had the feeling that it is...
/lgtm /label tide/merge-method-merge I restarted the CI (which had problem again :roll_eyes: ), this should merge now Thanks ! :+1:
Not sure where the merge conflict come from (or if Github is falsely detecting one), but try to rebase ?
I don't think we would need to use a fact, a registered variable is available during the rest of the playbook runs, so we can just use the registered variable...
> If I interpret the error message correctly, it is because the variable node_images does not remain set, contrary to the assumption. > > Unfortunately I can't explain 100% why...
> It seems the node_images variable is not preserved in the whole ansible run, because the file `check_pull_required.yml` are included dynamically via `include_tasks` in the download_container.yml file? > Aren't you...
>If that's the case I don't quite understand how Ansible handles variable registration. Since the first run can access node_images.stdout but the 2nd breaks with the fact that node_images has...