Valentin Hervieu

Results 223 comments of Valentin Hervieu

@twmulloy : Be careful, Javascript does not guarantee the order of object properties: http://stackoverflow.com/a/5525820/1713469

I just came to this issue after upgrading from v4 to v5. We have many dialogs where the first TextField label gets truncated as shared by @amaslakov above.

I just noticed the same issue: if I call `getSession()` to trigger a session update, the call is correctly sent by the context is not updated. I think I understand...

For now, I'm doing a full-reload navigation as a workaround.

Got this today, it's quite funny but should be fix! :smile:

Having this callback fired is mandatory as the crop data is dependent on the window size. However, you have a good point regarding deboucing. We should add a debounce [here](https://github.com/ricardo-ch/react-easy-crop/blob/main/src/index.tsx#L103)....

No it's fine as it's small enough 🙂

Indeed, it's better to only do the debounce for the `resize` event. `computeSizes` is used in multiple places and in some it has to be done immediately.

Indeed, something is wrong with the sizes computation. First thing I noticed is that `naturalWidth`/`naturalHeight` doesn't exist for SVGs and we are using this to measure to media size here:...