goto icon indicating copy to clipboard operation
goto copied to clipboard
verified publisher icon v3ss0n

CTRL+SHIFT+R Causes Atom to crash

Open JMVHill opened this issue 10 years ago • 19 comments

Using the above shortcut which should take me to the location of a declaration instead causes the editor to stop responding on windows and eventually crash.

JMVHill avatar Oct 21 '15 10:10 JMVHill

+1

vmalloc avatar Oct 25 '15 11:10 vmalloc

+1

tsipinio avatar Nov 10 '15 20:11 tsipinio

+1

ChrisBrough avatar Nov 10 '15 23:11 ChrisBrough

+1 on Mac

tobico avatar Nov 23 '15 00:11 tobico

+1 on Windows

erocheleau avatar Nov 24 '15 16:11 erocheleau

+1 Mac

kazkovsky avatar Dec 01 '15 12:12 kazkovsky

+1 on mac

sebastienrocks avatar Dec 07 '15 09:12 sebastienrocks

+1 Mac

joshschueler avatar Dec 15 '15 21:12 joshschueler

Idem with CMD+ALT+DOWN

ValentinH avatar Dec 23 '15 14:12 ValentinH

+1 mac

charleshaa avatar Feb 17 '16 13:02 charleshaa

+1 mac

jbogdani avatar Feb 21 '16 14:02 jbogdani

+1 on Linux

Costallat avatar Feb 22 '16 13:02 Costallat

This also happens to me on Mac, when opening middle-sized project. On small project it runs fine. Would love to see this scale so I can use Atom full time :smile:

I suspect this bug is performance-related (out of memory, or process killed because taking too much time)? I will try to learn the code when I get the chance.

dvdchr avatar Mar 07 '16 07:03 dvdchr

probably same bug: https://github.com/v3ss0n/goto/issues/16

despairblue avatar Mar 11 '16 08:03 despairblue

+1 Mac. My project folder is huge - over 3 GB - however the majority of that is in .gitignore. Does this plugin respect .gitignore?

EDIT: Actually, I can't even use it inside the goto source itself!

henrebotha avatar Apr 07 '16 09:04 henrebotha

The plugin had other issues other than the perf from indexing larger projects (mainly neglect), but as of 1.8.0, it should be working again, at least for its own source code.

I still sometimes have trouble using this plugin in larger codebases, but I can recommend a few techniques to help:

  • Make sure to include file names and extensions you don’t care about in your “More ignored names” options, like: .css .svg webpack.config.js package.json
  • Exclude your test files (could just be tests if all your tests are in a directory names tests or *.test.js if all of your test files have that suffix)

@henrebotha https://github.com/v3ss0n/goto/blob/master/lib/symbol-index.coffee#L188 is there to skip any paths that match any .gitignore entries.

acusti avatar Dec 11 '16 07:12 acusti

+1 Linux Mint. Interestingly, it works perfectly when i have no editor windows open. Once I have one open, ctrl+alt+r hangs/crashes.

broesdecat avatar Jan 05 '17 12:01 broesdecat

@broesdecat Any details about your project that causes the crash that you could share? Would be particularly great to have a repo or folder where the bug is reliably reproducible. Also, have you tried when opening different projects? Does it always crash, or only on some projects? Thanks!

acusti avatar Jan 05 '17 14:01 acusti

I tried to reproduce the issue today, but failed :( I no longer have the crash in the project in which I originally had it (https://github.com/tpaviot/oce/wiki) nor on another one I tried now.

I only started using Atom last week and continued to customize my environment after the crashes. It seems one of those changes also resolved the crash, but I do not expect to be able to pinpoint which one in retrospect...

broesdecat avatar Jan 09 '17 13:01 broesdecat