Dev Ojha

Results 383 comments of Dev Ojha

Not worth the time to fix the remaining test rn imo

Ah thanks! Maybe we should just move that solve_cfmm_direct function to testing and approx root to testing in stableswap then. Neither is used in the production state machine

yeah, and theres a number of nice add-ons to CodeQL in the SDK that I feel like we should be adding

We should definitely do this, I suggest using a constant amount of 30_000 gas.

Thanks for making this issue. I am in support of adding a new 15 minute one.

In the above PR I've fixed a lot of it, but there is still a lot of legacy usages of bigDec for liquidity in the code / tests we should...

As discussed in slack, I consider all of these as nice to haves personally, and not blockers for governance

> Programatic ranked quote asset order This is done right?

Thats a good point. I think that there should be some indication of how the proposal would be implemented. For non-minor changes, I think the API changes should have concrete...