Dev Ojha

icon company UC Berkeley, @sikkatech icon location I'm researching STARKs, working on github.com/scipr-lab/libiop, and am a student at UC Berkeley. I am interested in scaling blockchains. I CTF w/ @sicesquad

Results 383 comments of Dev Ojha

perf: Make mempool update async from block.Commit

> One problem of this approach is that this breaks the contract that we have regarding the ABCI `Commit` method: > > https://docs.cometbft.com/v0.38/spec/abci/abci++_app_requirements#commit > > > Before invoking Commit, CometBFT...

perf: Make mempool update async from block.Commit

I'm still stuck on the create empty blocks tests. Going to try more tomorrow. But somehow playing around with the timeouts / expanding leniency isn't fixing this. (Testing via running...

perf: Make mempool update async from block.Commit

I think the failing test cases is due to some race condition bug in the timeout ticker relating to ticks with negative durations. I added some logs, and in the...

perf: Make mempool update async from block.Commit

Ok just confirmed I get this same failure on main when I run the test in a loop, so its not new to this PR (and is an edge case...

perf: Make mempool update async from block.Commit

Great points! I think I addressed everything in your comments :)

perf: Make mempool update async from block.Commit

Yay all tests passing now that the timeout ticker bugfix got merged in!

perf: Make mempool update async from block.Commit

Sounds great, planning to get it into a patch release soon after this pr is merged

perf: Speedup flowrate by removing time.Now() from every update call

Great point! Fixed in latest commit

perf: Speedup flowrate by removing time.Now() from every update call

I think this PR is good to go!

perf: Speedup flowrate by removing time.Now() from every update call

Yes please, lets backport to 38!