Unity Chaos
Unity Chaos
It looks like the `IterateRangeInclusive` function isn't being called from anywhere in here, SDK or Burrow. So I think we would be fine to simply change it's callback signature to...
Umm also, and this might need to be a separate issue, but it looks to me like the Bank module is not doing any sort of author checking. https://github.com/f-o-a-m/kepler/blob/fe68362b06544c846dbc044e12b426b86c7abadb/hs-abci-sdk/src/Tendermint/SDK/Modules/Bank/Messages.hs#L51-L52 https://github.com/f-o-a-m/kepler/blob/fe68362b06544c846dbc044e12b426b86c7abadb/hs-abci-sdk/src/Tendermint/SDK/Modules/Bank/Router.hs#L26-L33...
I would say the simplest thing to do would be to call validateMessage before passing the data to the keeper handler. This could be done manually on every router function,...
This actually brings up another issue though, which is that parseTx requires recoverable signatures, and the upstream library has removed support for them in versions past 0.2.5 [Relevant Commit](https://github.com/haskoin/secp256k1-haskell/commit/0f862c2198d3ae47ad9028947f7507321079ab98) Signature...
Having read the blog post (thanks for that), I agree that parsing into types which constrain the data possibilities is definitely preferable to just "validation". As for the assumptions, I...
That is also my understanding of how prefixing works. There is a little bit of a concern about how to specify the entire range though. In your example it works...
Okay, so what the SDK does seems reasonable to me. https://github.com/cosmos/cosmos-sdk/blob/7fc5e3e6ab71fc6643176773e301d87b729ce549/store/types/utils.go#L68-L91 It just increments the last character by 1, so "abcd" -> "abce". Unless it ends with 0xFF, in which...
Might this create a problem with #254 though? I assume currently we never read key bytes from store and deserialize into the type, but when iterating through the Map presumably...