Ulises Gascón
Ulises Gascón
Ok! I made some progress on the topic, but I will need help to really do all the tweaks needed in Jenkins. So, let me summarize a bit the changes....
I won't have the time to work on this soon, so please feel free to claim this issue if you'd like to work on it.
As commented in https://github.com/expressjs/perf-wg/issues/36. Maybe we want to expand our tests and compare against releases rather than other frameworks as Fastify already provides great comparison tool: https://fastify.dev/benchmarks/ (https://github.com/fastify/benchmarks/). cc: @expressjs/express-tc
Good point @IamLizu! I was having similar issues recently with other actions that are generating PRs, I was thinking that maybe it is a GitHub issue, but maybe we need...
As https://github.com/expressjs/expressjs.com/pull/1710 landed this issue was solved as currently there is not pipeline :+1:
Until we feel comfortable with the automation (proposal in https://github.com/nodejs/email/pull/222) I agree that code owner requirement is a great idea :+1:
I will bring this to the next TC meeting https://github.com/expressjs/discussions/issues/370 and see if we need an exception to the ADR policy to land this on 1.0.1 :crossed_fingers:
Thanks for your contribution @Machinarius! :heart: The CI is failing as [email protected] does not support `^`, so I flagged this PR as a major change that will be included in...
Thanks for the ping! I will rework a bit in this pr
AFAIK: `crypto.timingSafeEqual` was introduced in v6.6.0 ([ref](https://nodejs.org/api/crypto.html#cryptotimingsafeequala-b)) so this is a major.