content-disposition icon indicating copy to clipboard operation
content-disposition copied to clipboard
verified publisher icon jshttp

fix: remove invalid engines field

Open Phillip9587 opened this issue 8 months ago • 5 comments

https://github.com/jshttp/content-disposition/pull/77#pullrequestreview-2804731439

cc: @UlisesGascon @blakeembrey

Phillip9587 avatar May 05 '25 14:05 Phillip9587

@bjohansebas We have to options for the next release. Remove the emgines field and release v1.0.1 or publish v2

Phillip9587 avatar May 05 '25 15:05 Phillip9587

@Phillip9587 @blakeembrey This PR would go against what this ADR proposes (https://github.com/expressjs/discussions/pull/289)

bjohansebas avatar May 05 '25 15:05 bjohansebas

@bjohansebas it was noted in the comment by @wesleytodd but I’ve added a review to clarify it in the ADR since it seems to be confusing:

The only thing I think is missing is the call-out that all more restrictive engines changes can only land with a MAJOR. And that we agreed major versions should not be cut just to change node support.

blakeembrey avatar May 05 '25 15:05 blakeembrey

I will bring this to the next TC meeting https://github.com/expressjs/discussions/issues/370 and see if we need an exception to the ADR policy to land this on 1.0.1 :crossed_fingers:

UlisesGascon avatar May 09 '25 13:05 UlisesGascon

@UlisesGascon Has there been a decision from the TC?

Phillip9587 avatar May 16 '25 07:05 Phillip9587