Tyler Helmuth

Results 799 comments of Tyler Helmuth

I also think that the implementation of a `Pipeline ID` and `Signal` would not (should not?) live in `component`. If `component` exists as a definition of what a Component is...

What happens to ocb users who depended on CGO being enabled? Will their builds work but have issues at runtime or will they just fail to build?

I think it could wait until after 1.0 according to our version controls: >Relaxing validation rules. An invalid configuration struct as defined by its Validate method return value may become...

A downside to this approach is that the logs come in a weird order. This is highlighted in the description's screenshot.

Another potential downside I need to investigate: if there is an error during confmap resolution will the logs still be written

> if there is an error during confmap resolution will the logs still be written The answer is no, the logs will not be written. So if we wanted to...

> I think this is a more scalable solution given that providers may want to do additional logging in the future (e.g. an HTTP provider that polls an endpoint can't...

@evan-bradley I don't think either option 1 or 2 will solve the problem of trying to have an the actual user-configured logger during config resolution since they don't solve the...

> We could get around this by passing a wrapper struct that allows us to update the instance reference so long as providers access the logger only through the wrapper....

> I think to make it fully enforceable we would need to fully wrap *zap.Logger and keep the instance reference hidden. Agreed, `ProviderSettings` would need to look something like ```go...