Tyler Helmuth

Results 799 comments of Tyler Helmuth

@TylerHelmuth If I understand json schema correctly you could write a schema file and use it to validate the config externally (not inside the collector) correct?

I recommend you write and maintain your own file specific to your collector build. Since the collector is composable from components from anywhere, and those components can use any configuration...

@yurishkuro I agree that we could improve the consistency and quality of component documentation - being able to auto-generate standard docs from component config would be awesome. What I'm arguing...

> The collector will call shutdown on the component (when the collector is shutting down) and we should allow the status to reflect that. Yes this seems totally valid. As...

One argument for leaving it in core is to try to help components aggregate statuses in a consistent manner so that the meaning of a `Status` is consistent between components....

I really want this feature. The glob-style matching is really interesting. It would easily let you turn off a set of metrics you don't want, like `*__replicas` to turn off...

Supporting full glob is probably ok.

If we used globs, I think we need more rules for how clashes interact. It feels like wanting to do something like ```yaml metrics: '*': enabled: false "k8s.pod.*": enabled: true...

Not allowing clashes at the start would be really nice, but I think will take away a lot of the use cases. The implementation will help users who want to...

> You just disable all of them with * and enable some of them explicitly by names Oh I was under the impression that would be considered a clash. If...