Michael Matloka
Michael Matloka
I think we have this handled for a lot of cases
If we did not have Actions and Cohorts I would say this is a no-brainer, but we already have them, and they already are saved filters in essence – as...
Schema purity 📉 Practicality 📈 ✅
Unfortunately it seems while `transaction.on_commit` [generally _can_ be tested](https://docs.djangoproject.com/en/5.0/topics/testing/tools/#django.test.TestCase.captureOnCommitCallbacks), here this isn't quite working. Might not be worth a deeper investigation.
@coderabbitai review
These comments are pretty dumb honestly
Hmm, we do already have a breakpoint in `loadRemoteItems` itself – so we shouldn't need one _before_ calling that. Wonder what am I missing.
@mariusandra I see you've re-ran the backend tests, but they aren't doing that badly, they've caught some actual issues. 😅 The big one is that HogQLQueryResponse doesn't conform to CachedQueryResponse,...
Unfortunately this seemingly simple quest required shaving a yak, and this is a pretty big yak as far as yaks go. They don't actually go _very_ far, as they weight...
> Why do we have always calculate or never? @webjunkie It's just how QueryRunners have been implemented since the beginning. I agree that what's now `CALCULATION_ALWAYS` should in fact return...