posthog icon indicating copy to clipboard operation
posthog copied to clipboard

refactor(clickhouse): Streamline query task initiation

Open Twixes opened this issue 1 year ago • 2 comments

Problem

Currently our query initiation behavior is a bit different in tests and outside of them. Only in production do we use transaction.on_commit.

Changes

Let's be consistent between tests and prod.

How did you test this code?

Just needs all the tests to pass.

Twixes avatar May 09 '24 15:05 Twixes

Unfortunately it seems while transaction.on_commit generally can be tested, here this isn't quite working. Might not be worth a deeper investigation.

Twixes avatar May 09 '24 16:05 Twixes

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

posthog-bot avatar May 17 '24 07:05 posthog-bot