posthog
posthog copied to clipboard
fix: add debounce to infinite list
Problem
There's no debounce so we're firing off a bunch of requests
Changes
đ Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
How did you test this code?
Size Change: 0 B
Total Size: 1.05 MB
âšī¸ View Unchanged
| Filename | Size |
|---|---|
frontend/dist/toolbar.js |
1.05 MB |
đ¸ UI snapshots have been updated
2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)webkit: 0 added, 0 modified, 0 deleted
Triggered by this commit.
Hmm, we do already have a breakpoint in loadRemoteItems itself â so we shouldn't need one before calling that. Wonder what am I missing.
đ¸ UI snapshots have been updated
2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)webkit: 0 added, 0 modified, 0 deleted
Triggered by this commit.
I was under the impression I added appropriate debounce when I was at it. Can have a look later.
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label â otherwise this will be closed in another week.
@timgl Where did you see this change fixing an issue?
I tested this on the breakdown popup, which definitely hits this code path, and it does seem like it's already properly debounced without this addition.
Yup, also checked, and the await breakpoint() in loadRemoteItems works for me too â so this doesn't seem needed.