Pascal Obry

@kmilos : After all the side discussions with compilation issues... Finally is that ready for merging?

Hi @phweyland , no problem, no urgency. I'll wait for you testing. Thanks.

@phweyland : This is becoming a bit urgent as we are approaching feature freeze, can you have a look? TIA.

Also this new module must be added into `src/lib/modulegroups.c` in "module : all" presets. See around line 1642.

I also confirm issue with full black image when using local contrast discussed in pixls.us here https://discuss.pixls.us/t/new-sigmoid-scene-to-display-mapping/22635/711?u=pascal_obry

About the black images have you double checked that the values set in data (in commit_params) are in proper range?

> What is the support for unit tests in the darktable code base? See `src/tests/unittests/iop`. But indeed a very light testing on this part. We also have an integration testsuite...

BTW, I'll be happy to add the integration test when this is merged.

@jandren : Just checking, are you able to reproduce the full black output when using local contrast?

@jandren : Some testing shows that I don't have the full black output anymore now, that's great! > Found that the rgb ratio mode has a similar problem for extreme...